Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring eurotherm tests to work with multiple sensors #625

Merged
merged 22 commits into from
Nov 28, 2024
Merged

Refactoring eurotherm tests to work with multiple sensors #625

merged 22 commits into from
Nov 28, 2024

Conversation

esmith1729
Copy link
Contributor

@esmith1729 esmith1729 commented May 13, 2024 •
edited
Loading

Added unit test for new functionality created from

can be tested with:

python -u run_tests.py -t eurotherm_eibisynch.EurothermTests.test_WHEN_eurotherm_missing_THEN_updates_of_PVs_stop

@esmith1729 esmith1729 linked an issue May 14, 2024 that may be closed by this pull request
eurotherm: handle missing sensor better ISISComputingGroup/IBEX#8310
Closed
@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 4, 2024
@esmith1729
add sensor list, change backdoor set to backdoor run function
2c06ed8
@esmith1729
Change backdoor set to backdoor run function, and add sensors list
df795bc
@esmith1729
Add test to check that one sensor can disconnect, and another can sti…
2cb3644 
…ll read
@esmith1729
made sensors and pv_sensors constants, and import contextmanager, add…
cb3e858 
…ed return type hints to methods to satisfy ruff fixes
@esmith1729
various fixes to satisfy ruff and pyright
b8f2e2d
@esmith1729
Change name of method parameter to not have conflicts with eibisynch …
7af68e8 
…method of same name
@esmith1729
Change name of method parameter to not conflict with method of same n…
ec53a65 
…ame in eurotherm tests
@esmith1729
Format fixes for ruff and pyright, add LewisLauncher to setUp to fix …
0dba4af 
…ruff error
@esmith1729
Made sensors constant, some file reformatting for ruff, add LewisLaun…
0530b4b 
…cher to setUp
@esmith1729
set_delay_time now no longer takes an address
fad7212
@esmith1729
missed on address
7e31bf2
@esmith1729
assert_that_pv_is_not_number's tolerance should default to float 0.0
5cb841b
@esmith1729
Changes for ruff/pyright errors
145f57c
@esmith1729
Ruff formatting
ba36337
@esmith1729
Copy link
Contributor Author

Linter is failing for utils\emulator_launcer.py, this should be reformatted during a "Ruff day", it will also need some changes due to pyright, I would guess, but that falls outside of scope of this ticket.

@esmith1729 esmith1729 changed the title Add basic test for disconnected eurotherm Refactoring eurotherm tests to work with multiple sensors Nov 11, 2024
@esmith1729 esmith1729 mentioned this pull request Nov 11, 2024
Closed
@Chsudeepta Chsudeepta merged commit 0cc052b into master Nov 28, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chsudeepta Chsudeepta Chsudeepta approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

eurotherm: handle missing sensor better
2 participants
@esmith1729 @Chsudeepta